rusackas opened a new pull request, #37881:
URL: https://github.com/apache/superset/pull/37881
### SUMMARY
This PR addresses numerous console warnings that appear during development,
improving the developer experience and reducing noise in the browser console.
**Fixes include:**
1. **Ant Design deprecation warnings:**
- `destroyTooltipOnHide` → `destroyOnHidden` (Tooltip/Popover)
- Menu `children` → `items` prop pattern
- Modal `bodyStyle` → `styles.body`
2. **React warnings:**
- Missing `key` props in list renders (ActionsBar, DndFilterSelect)
- Memory leak warnings from async operations in unmounted components
(ActivityTable, SubMenu)
- Ref forwarding issues with Emotion's css prop (wrapped elements in
`<span>`)
3. **Emotion CSS warnings:**
- `:first-child` → `:first-of-type` for SSR safety (13 files)
4. **ECharts warning:**
- Pass `width`/`height` to `init()` to prevent "Can't get DOM width or
height" warning
5. **DOM attribute warnings:**
- Use `shouldForwardProp` to prevent `$empty` prop from leaking to DOM
(DatabaseSelector)
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - Console output changes only
### TESTING INSTRUCTIONS
1. Start the dev server (`npm run dev`)
2. Navigate to various pages: `/welcome`, `/dashboard/list`, `/explore`,
`/sqllab`, `/roles`
3. Open browser DevTools console
4. Verify reduced console warnings compared to master branch
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
