bito-code-review[bot] commented on code in PR #37857:
URL: https://github.com/apache/superset/pull/37857#discussion_r2792082031
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Heatmap/Heatmap.tsx:
##########
@@ -122,7 +123,9 @@ export const getLayer: GetLayerType<HeatmapLayer> = ({
const colorScale = getSequentialSchemeRegistry()
?.get(colorScheme)
- ?.createLinearScale([0, 6]);
+ ?.createLinearScale([0, 6]) as
+ | ScaleLinear<string, string, never>
+ | undefined;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect ScaleLinear type assertion</b></div>
<div id="fix">
The type assertion uses ScaleLinear<string, string, never>, but d3-scale's
ScaleLinear has a numeric domain for linear scales. The domain [0, 6] is
numeric, so it should be ScaleLinear<number, string, never>. This mismatch
could cause type confusion if the scale's domain methods are used elsewhere.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
?.createLinearScale([0, 6]) as
| ScaleLinear<number, string, never>
| undefined;
````
</div>
</details>
</div>
<small><i>Code Review Run #a3c140</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
