villebro opened a new pull request, #37900: URL: https://github.com/apache/superset/pull/37900
### SUMMARY Improve performance and logic of Task base filter: 1. `IN` (subquery) → `EXISTS` to short-circuits on first match, better query plan optimization. 2. Removed redundant `created_by_fk` check - Creators are auto-subscribed, so subscription-only filtering covers both owned and shared tasks. Creators should also no longer see tasks after they've unsubscribed. 3. Removed dead `TaskSubscriberFilter` class - Never used. 4. Added integration tests to ensure multi-user subscrbibe/unsubscribe flow results in expected list behavior. <!--- Describe the change below, including rationale and design decisions --> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
