bito-code-review[bot] commented on code in PR #37906:
URL: https://github.com/apache/superset/pull/37906#discussion_r2795321014
##########
superset/reports/api.py:
##########
@@ -82,6 +82,11 @@ def ensure_alert_reports_enabled(self) -> Optional[Response]:
resource_name = "report"
allow_browser_login = True
+ extra_fields_rel_fields = {
+ "owners": ["email", "active", "username"],
+ "created_by": ["email", "active", "username"],
+ }
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>API Response Structure Change</b></div>
<div id="fix">
The addition of extra_fields_rel_fields and 'owners.username' to
show_columns/list_columns modifies the API response structure for owners,
including username in the top-level fields. However, the existing test in
api_tests.py expects owners to have only ['first_name', 'id', 'last_name'],
which will now fail as username is added. This appears to be an unintended
breaking change to the API contract.
</div>
</div>
<small><i>Code Review Run #bc8170</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
