richardfogaca commented on code in PR #37459: URL: https://github.com/apache/superset/pull/37459#discussion_r2796210917
########## superset-frontend/src/dashboard/hooks/useTabVisibility.ts: ########## @@ -0,0 +1,102 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { useEffect, useRef, useCallback, useState } from 'react'; + +export interface UseTabVisibilityOptions { + /** Callback when tab becomes visible */ + onVisible?: () => void; + /** Callback when tab becomes hidden */ + onHidden?: () => void; + /** Whether the hook is enabled */ + enabled?: boolean; +} + +export interface UseTabVisibilityResult { + /** Whether the tab is visible */ + isVisible: boolean; +} + +/** + * Hook to track browser tab visibility state. + * Uses the Page Visibility API to detect when the user switches tabs. + * + * @example + * ```tsx + * const { isVisible } = useTabVisibility({ + * onVisible: () => console.log('Tab is visible'), + * onHidden: () => console.log('Tab is hidden'), + * }); + * ``` + */ +export function useTabVisibility({ + onVisible, + onHidden, + enabled = true, +}: UseTabVisibilityOptions = {}): UseTabVisibilityResult { + const [isVisible, setIsVisible] = useState( + () => document.visibilityState === 'visible', + ); Review Comment: Good question. This is using the standard Page Visibility API (`document.visibilityState` + `visibilitychange`), which tracks page/tab visibility, not document body visibility. Even though it’s accessed through `document`, the semantics are tab/page-level: `visible` for foreground tab, `hidden` for background/minimized states. So this is the intended browser API for this behavior, not a workaround. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
