goldjee commented on code in PR #37932:
URL: https://github.com/apache/superset/pull/37932#discussion_r2800339593
##########
superset/commands/dataset/duplicate.py:
##########
@@ -66,6 +66,7 @@ def run(self) -> Model:
table = SqlaTable(table_name=table_name, owners=owners)
table.database = database
table.schema = self._base_model.schema
+ table.catalog = self._base_model.catalog
Review Comment:
Duplicates should preserve base model properties. This is intuitive and
expected behavior. I have fixed the inconsistency, though, by removing `or
database.get_default_catalog()` from the validation function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
