rusackas opened a new pull request, #37945:
URL: https://github.com/apache/superset/pull/37945

   ## Summary
   
   Adds database engine specs with metadata and logos for five databases that 
have SQLAlchemy dialects but were missing from Superset's database connection 
UI:
   
   - **PostGIS** - PostgreSQL spatial database extension (uses standard 
psycopg2 driver)
   - **DoltDB** - MySQL-compatible version-controlled database
   - **TiDB** - MySQL-compatible distributed HTAP database (supports both 
mysqlclient and native sqlalchemy-tidb drivers)
   - **QuestDB** - High-performance time-series database with custom time grain 
expressions
   - **Timeplus** - Streaming-first analytics platform with custom time grain 
expressions
   
   Also fixes a bug where MSSQL's logo wasn't displaying due to an incorrect 
filename reference (`msql.png` → `mssql-server.png`).
   
   ## Changes
   
   ### New Engine Specs
   - `superset/db_engine_specs/postgis.py` - Extends PostgresBaseEngineSpec
   - `superset/db_engine_specs/doltdb.py` - Extends MySQLEngineSpec
   - `superset/db_engine_specs/tidb.py` - Extends MySQLEngineSpec with multiple 
driver options
   - `superset/db_engine_specs/questdb.py` - New BaseEngineSpec with 
timestamp_floor() time grains
   - `superset/db_engine_specs/timeplus.py` - New BaseEngineSpec with 
date_trunc() time grains
   
   ### New Logo Files
   - `superset-frontend/src/assets/images/postgis.svg`
   - `superset-frontend/src/assets/images/doltdb.png`
   - `superset-frontend/src/assets/images/tidb.svg`
   - `superset-frontend/src/assets/images/questdb.png`
   - `superset-frontend/src/assets/images/timeplus.svg`
   
   ### Bug Fix
   - `superset/db_engine_specs/mssql.py` - Fixed logo reference
   
   ## Test plan
   
   - [ ] Verify new databases appear in the database connection dropdown
   - [ ] Verify logos display correctly for each database
   - [ ] Verify MSSQL logo now displays (was broken before)
   - [ ] For databases with time grain expressions (QuestDB, Timeplus), verify 
time grain options work in chart builder
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to