rusackas commented on PR #37923: URL: https://github.com/apache/superset/pull/37923#issuecomment-3894179368
Fixed the CI failure in fa9acd8b25. The `utc()` factory method was missing the third `strict` parameter that's available when the `customParseFormat` plugin is loaded. Code in `BigNumber/utils.ts` was calling `dayjs.utc(metricValue, undefined, true)` with 3 arguments but the type only allowed 2. **Re: the type safety review comment** - the suggestion to return `ExtendedDayjs` instead of `Dayjs` for proper chaining was already applied in 7ff3e0ad48 (as noted by @rusackas). This additional fix adds the `strict?: boolean` parameter to both the factory function and `utc()` signatures to match dayjs's actual API when customParseFormat is loaded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
