bito-code-review[bot] commented on code in PR #37488:
URL: https://github.com/apache/superset/pull/37488#discussion_r2803137489
##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopoverTrigger.test.tsx:
##########
@@ -33,7 +33,11 @@ const createStore = (datasource = {}) =>
configureStore({
reducer: {
explore: () => ({
- datasource,
+ past: [],
+ present: {
+ datasource,
+ },
+ future: [],
}),
},
});
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>State selector mismatch</b></div>
<div id="fix">
The test mock correctly reflects the new undoable state structure with
past/present/future, but the component's selector in
`ColumnSelectPopoverTrigger.tsx` still accesses the old path. This will cause
the component to receive undefined datasource at runtime, breaking column
selection functionality.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
- (state: any) => state?.explore?.datasource || null,
+ (state: any) => state?.explore?.present?.datasource || null,
```
</div>
</details>
</div>
<small><i>Code Review Run #10649f</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
