ramiroaquinoromero commented on code in PR #37501:
URL: https://github.com/apache/superset/pull/37501#discussion_r2805461161
##########
superset-frontend/src/explore/components/ExploreChartPanel/index.tsx:
##########
@@ -282,7 +305,7 @@ const ExploreChartPanel = ({
})}
{...(chart.chartStatus && { chartStatus: chart.chartStatus })}
/>
- )}
+ ) : null}
</div>
Review Comment:
We use the ternary so we never render a falsy value (like 0). With &&, if
width or height is 0, React would show that "0" on screen, with ? : null we
only render the chart or nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
