veeceey opened a new pull request, #37975:
URL: https://github.com/apache/superset/pull/37975
### SUMMARY
The DrillDetailPane fetches data in fixed pages of 50, but the Table
component's default `pageSizeOptions` (`[5, 15, 25, 50, 100]`) were shown in
the pagination dropdown. This caused two issues:
1. Selecting a smaller page size (e.g., 5) let users jump to pages beyond
what was actually fetched, showing empty results
2. Selecting 100 only displayed 50 rows since the backend always returns 50
The fix passes `pageSizeOptions={['50']}` to the Table so the page size
selector only shows the one valid option. This is the simplest correct fix
since the page size is currently a constant (`PAGE_SIZE = 50`) and there's no
mechanism to actually change the fetch size.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**Before:** Page size dropdown shows 5, 15, 25, 50, 100 -- selecting
anything other than 50 breaks pagination
**After:** Page size dropdown only shows 50
### TESTING INSTRUCTIONS
1. Open any chart and click "Drill to detail"
2. Verify the page size selector only shows "50 / page"
3. Navigate through pages to verify pagination works correctly
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #36267
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
