hainenber opened a new pull request, #37990: URL: https://github.com/apache/superset/pull/37990
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> fix(docs): correct DB module filename for editing ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Fixes below issue in [`Supported databases` pages](https://superset.apache.org/docs/databases/supported/amazon-dynamodb) whereby URL for editing the DB module file is completely amiss. <img width="813" height="476" alt="image" src="https://github.com/user-attachments/assets/eb08f84b-9304-4213-af3f-1cebce664091"; /> <img width="1027" height="476" alt="image" src="https://github.com/user-attachments/assets/ae45cdeb-47f7-4170-8152-f20de4f01cc9"; /> Due to how DB diagnostics file got generated in `python-integrationtest` CI, the `module` value is prefixed with `superset.db_engine_specs`. When `Docs Deployment` CI reused said artifacts without further modifications, the bug materializes. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Before is already present in the current docs, [`AWS Athena` for example](https://superset.apache.org/docs/databases/supported/amazon-athena). After with testing instructions to simulate running `Docs Deployment ` in CI <img width="1027" height="476" alt="image" src="https://github.com/user-attachments/assets/997f2b98-3e9b-4627-823c-9e641bda29f1"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Go to latest `python-integrationtest` CI step and download the databases-diagnostics build artifacts 2. Unzip said build artifact and replace the `docs/src/data/databases.json` with the unzipped JSON 3. Make sure you have `superset` installed in your dev env 4. Go to `/docs` and run `node scripts/generate-database-docs.mjs` 5. Run `yarn build` and `yarn serve` to compare. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
