LevisNgigi commented on code in PR #37445:
URL: https://github.com/apache/superset/pull/37445#discussion_r2810985372
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx:
##########
@@ -524,7 +524,11 @@ test('deletes a filter including dependencies', async ()
=> {
);
}, 30000);
-test('reorders filters via drag and drop', async () => {
+// dnd-kit's PointerSensor requires a real browser environment with proper
+// pointer event handling that JSDOM doesn't fully support. This test should
+// be covered by Playwright E2E tests instead.
+// eslint-disable-next-line jest/no-disabled-tests
+test.skip('reorders filters via drag and drop', async () => {
Review Comment:
addressed it
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx:
##########
@@ -524,7 +524,11 @@ test('deletes a filter including dependencies', async ()
=> {
);
}, 30000);
-test('reorders filters via drag and drop', async () => {
+// dnd-kit's PointerSensor requires a real browser environment with proper
+// pointer event handling that JSDOM doesn't fully support. This test should
+// be covered by Playwright E2E tests instead.
+// eslint-disable-next-line jest/no-disabled-tests
+test.skip('reorders filters via drag and drop', async () => {
Review Comment:
addressed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
