rusackas commented on PR #35897: URL: https://github.com/apache/superset/pull/35897#issuecomment-3922667454
>I don’t think it’s necessary to color both, so I don’t believe it should be allowed. >At the moment, I don’t see this as a major issue, but we can gather additional feedback. >@rusackas , what do you think? I agree, it would be _better_ not to allow this possibility, but I don't want to block the PR over it if this is already an existing problem. Maybe it's possible to address this in a follow-up PR to make better dynamic controls, so you have to pick one or the other (hiding/showing/disabling the relevant fields). But again, this seems like an enhancement that's relevant with our without this PR, so I'm OK with that being a different PR. As for the bold font... if we can live without the additional font style definition, that's great, but it also doesn't seem like it's doing any major harm, and can be addressed as a fix if it does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
