betodealmeida commented on PR #38075:
URL: https://github.com/apache/superset/pull/38075#issuecomment-3923335753
> Your suggestion to change `encrypted_extra_sensitive_fields` to a union
type `set[str] | dict[str, str]` provides backward compatibility and simplifies
maintenance by avoiding the need to sync it with
`encrypted_extra_sensitive_field_labels`. The handling code you provided
converts a set to a dict when needed, which is a clean approach. For the
autogeneration of labels, it could work but might introduce inconsistency if
field names don't map well to readable labels.
>
> **superset/db_engine_specs/base.py**
>
> ```
> encrypted_extra_sensitive_fields: set[str] | dict[str, str] = {"$.*"}
> ```
It would generate the label `*`, which I'd argue is not bad, Mr. AI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
