bito-code-review[bot] commented on PR #38101:
URL: https://github.com/apache/superset/pull/38101#issuecomment-3928295750
<!-- Bito Reply -->
The suggestion is valid — using .some() on the array [name, verboseName,
expression] provides a more concise and readable way to check if any field
matches the search, equivalent to the existing || chain.
**superset-frontend/src/components/Datasource/FoldersEditor/folderOperations.ts**
```
if ([name, verboseName, expression].some(s =>
s?.toLowerCase().includes(lowerSearch))) {
matchingIds.add(item.uuid);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
