bito-code-review[bot] commented on PR #38078:
URL: https://github.com/apache/superset/pull/38078#issuecomment-3928305000
<!-- Bito Reply -->
Yes, extracting this type to a shared interface would be a good idea for
maintainability. The type `{ fileName: string; fields: { path: string; label:
string }[] }[]` appears in DatabaseModal, ImportModal types, and hooks. You
could define it as `EncryptedExtraFields[]` in a shared types file, leveraging
the existing `EncryptedExtraField` interface from utils.tsx.
**superset-frontend/src/views/CRUD/types.ts**
```
import { EncryptedExtraField } from './utils';
export type EncryptedExtraFields = {
fileName: string;
fields: EncryptedExtraField[];
}[];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
