sfirke commented on PR #37712: URL: https://github.com/apache/superset/pull/37712#issuecomment-3935894677
@YousufFFFF - please see [my comment above where I have three screenshots](https://github.com/apache/superset/pull/37712#issuecomment-3873527775) and the third one - the ultimate test case - is not correct in the test environment. When I try to recreate that third chart in the current test environment, it's different than before, but I think it's wrong: <img width="2166" height="1115" alt="image" src="https://github.com/user-attachments/assets/6910014f-df51-43f9-b71c-300a53fd56cd"; /> It looks to me like despite setting X-Axis Sort By to `SUM(na_sales)`, the chart bars are ordering by the *metric*, `COUNT(*)`. The order of the bars should match my second screenshot in the linked comment and should not change when we add a dimension. Right now the x-axis sort order changes when we add or remove a dimension which is not right. Please investigate. Before you mark this as ready for review again, can you document with a screenshot that it can produce the third chart correctly: one variable for the X-axis (defines the bar groups), another for the X-Axis sort by (how they are ordered), a third for the metric (how tall the bars are), and a fourth for the dimension (the colored segments of the bars)? Let me know if you think my assessment of the situation is off. Thanks for your continued work on this - in my opinion, this is the biggest bug currently affecting Superset, so it would be amazing to get this merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
