michael-s-molina opened a new pull request, #38127: URL: https://github.com/apache/superset/pull/38127
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Simplifies the `registerEditorProvider` API by removing redundant metadata that is already declared in `extension.json`. **Before:** Extension authors had to pass the full `EditorContribution` object (id, name, languages, description) even though the same information is already in the manifest: ```typescript editors.registerEditorProvider( { id: 'acme.monaco-sql', name: 'Monaco SQL Editor', languages: ['sql'] }, MonacoSQLEditor, ); ``` **After:** Only the contribution ID and component are needed — metadata is resolved from the manifest automatically, matching the `registerViewProvider` pattern: ```typescript editors.registerEditorProvider('acme.monaco-sql', MonacoSQLEditor); ``` ### TESTING INSTRUCTIONS 1. Verify existing editor tests pass: `npx jest --no-coverage src/core/editors/` 2. Load an extension that registers an editor provider using the new `(id, component)` signature 3. Confirm the editor renders in the expected locations (SQL Lab, Dashboard CSS, etc.) 4. Confirm a warning is logged if a non-existent ID is passed to `registerEditorProvider` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
