EnxDev commented on issue #37927: URL: https://github.com/apache/superset/issues/37927#issuecomment-3936896441
> Thanks for the proposal [@EnxDev](https://github.com/EnxDev). Some thoughts: > > * It might be better to consolidate related configs under a single config key by using a `Dict` as the value, rather than maintaining multiple separate keys. > * I don’t think admins should be able to set user passwords, especially since admins can leave or change roles within the organization. Instead, we should always send a reset link to users. > * Instead of creating a separate `password_reset_token` table, maybe we could leverage the existing `key_value` table to store reset tokens. > * It could be helpful to add an `auth` prefix to all authentication-related tables, such as renaming `account_lockout` to clarify their purpose. Thanks for sharing your thoughts. I’ve updated the SIP accordingly. > * Since these changes are already controlled by `AUTH_TYPE = AUTH_DB`, is there a need for an additional feature flag? All of these features seem like a natural part of what database authentication provides. I don’t believe an additional feature flag is necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
