bito-code-review[bot] commented on code in PR #37880:
URL: https://github.com/apache/superset/pull/37880#discussion_r2837397902
##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.test.tsx:
##########
@@ -390,7 +392,7 @@ test('can drop a saved metric when disallow_adhoc_metrics',
() => {
expect(currentMetric.children[1]).toHaveTextContent('metric_a');
});
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Skipped test reduces behavior coverage</b></div>
<div id="fix">
Skipping this test reduces coverage for the disallow_adhoc_metrics behavior,
which could allow bugs in metric dropping logic to go undetected. Consider
updating the test for @dnd-kit compatibility rather than skipping.
</div>
</div>
<small><i>Code Review Run #4c915c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
