marcioibm commented on PR #38191: URL: https://github.com/apache/superset/pull/38191#issuecomment-3946182897
> ### Code Review Agent Run #5280d3 > Actionable Suggestions - 0 > Additional Suggestions - 1 > * superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.tsx - 1 > > * Broken string temporal formatting · [Line 846-846](https://github.com/apache/superset/pull/38191/files#diff-2262a1df103fda91ff939105e998b8a96ed3e05ad84d75d8c5afcc13c5b899fdR846) > Use `Number(v)` when it yields a valid number and fallback to the original value on NaN. For example: > ```js > const n = Number(v); > const headerCellFormattedValue = dateFormatters?.[attrName]?.(isNaN(n) ? v : n) ?? v; > ``` > > Review Details > * Files reviewed - 1 · Commit Range: `7735e28..8163ae8` > > * superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.tsx > * Files skipped - 0 > * Tools > > * Whispers (Secret Scanner) - ✔︎ Successful* Detect-secrets (Secret Scanner) - ✔︎ Successful > > Bito Usage Guide > **Commands** > > Type the following command in the pull request comment and save the comment. > > * `/review` - Manually triggers a full AI review. > * `/pause` - Pauses automatic reviews on this pull request. > * `/resume` - Resumes automatic reviews. > * `/resolve` - Marks all Bito-posted review comments as resolved. > * `/abort` - Cancels all in-progress reviews. > > Refer to the [documentation](https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands) for additional commands. > > **Configuration** > > This repository uses `Superset` You can customize the agent settings [here](https://alpha.bito.ai/home/ai-agents/code-review-agent) or contact your Bito workspace admin at [[email protected]](mailto:[email protected]). > > **Documentation & Help** > > * [Customize agent settings](https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance) > * [Review rules](https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules) > * [General documentation](https://docs.bito.ai/bito-dev-agents/ai-code-review-agent) > * [FAQ](https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs) > > AI Code Review powered by [<img alt="Bito Logo" width="50" height="20" src="https://camo.githubusercontent.com/810f9c950a15f18a9a21d4e214820ef360ea3b08a4b5dea95d24529fffd09ed6/68747470733a2f2f6269746f2e61692f77702d636f6e74656e742f75706c6f6164732f323032332f31302f4c6f676f2d4269746f2d426c61636b2d63726f707065642e737667";>](https://bito.ai/) The suggested behavior happens when trying to format an invalid number and fallbacks to String! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
