michael-s-molina opened a new pull request, #38217:
URL: https://github.com/apache/superset/pull/38217
### SUMMARY
Previously, a single misconfigured or broken extension in `LOCAL_EXTENSIONS`
(e.g. a missing `dist/` directory) would raise an unhandled exception and abort
loading of all extensions.
This change wraps each `LOCAL_EXTENSIONS` entry in a `try/except` block so
that a failure in one extension is logged and skipped, allowing the remaining
extensions to load normally. The error logging pattern matches the one already
used in `discover_and_load_extensions`.
**Before:** one bad extension path crashes the entire extension loading
pipeline.
**After:** one bad extension path logs an error and is skipped; other
extensions load normally.
### TESTING INSTRUCTIONS
1. Add a path to `LOCAL_EXTENSIONS` in `superset_config.py` that does not
have a `dist/` directory, e.g.:
```python
LOCAL_EXTENSIONS = ["/path/to/broken-extension",
"/path/to/valid-extension"]
```
2. Start Superset.
3. **Before:** `GET /api/v1/extensions/` returns a 500 error and no
extensions load.
4. **After:** the broken path produces a `logger.error` entry and the valid
extension loads successfully.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
