aminghadersohi commented on code in PR #37972:
URL: https://github.com/apache/superset/pull/37972#discussion_r2854115209
##########
superset/mcp_service/mcp_config.py:
##########
@@ -182,30 +189,34 @@ def create_default_mcp_auth_factory(app: Flask) ->
Optional[Any]:
return None
try:
- from fastmcp.server.auth.providers.jwt import JWTVerifier
+ from superset.mcp_service.jwt_verifier import DetailedJWTVerifier
+
+ debug_errors = app.config.get("MCP_JWT_DEBUG_ERRORS", False)
# For HS256 (symmetric), use the secret as the public_key parameter
if app.config.get("MCP_JWT_ALGORITHM") == "HS256" and secret:
- auth_provider = JWTVerifier(
+ auth_provider = DetailedJWTVerifier(
Review Comment:
Good call — addressed in b2a731c. When `MCP_JWT_DEBUG_ERRORS=False` (the
default), the factory creates a standard `JWTVerifier` from fastmcp.
`DetailedJWTVerifier` is only instantiated when the flag is `True`. See
`mcp_config.py` lines 211-222.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
