kgabryje opened a new pull request, #38252: URL: https://github.com/apache/superset/pull/38252
### SUMMARY When search is active in the dataset modal's Folders tab, shift-clicking to range-select items would also select items hidden by the search filter. This is because the shift-select logic filtered `flattenedItems` to exclude only folders, but did not exclude items hidden by the search. The fix adds a `visibleItemIds.has(item.uuid)` check to the selectable items filter, so only items matching the current search query are included in the shift-click range selection. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS 1. Open a dataset modal and go to the Folders tab 2. Type a search term that filters down the list of metrics/columns 3. Click one visible item, then shift-click another visible item 4. Verify that only visible (search-matching) items in the range are selected, not hidden ones ### ADDITIONAL INFORMATION - [x] Has associated issue: https://app.shortcut.com/preset/story/99964 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
