goldjee commented on issue #38215: URL: https://github.com/apache/superset/issues/38215#issuecomment-3961007825
If I may add my two cents to the discussion, it feels like this modal has acquired a lot of new elements throughout the years, and now it needs some love. My main issue is with metrics, columns, and calculated columns tabs. - Each entity has quite a few attributes, some of which are crammed into a table and others are just free hanging inside an expand/collapse row button. - I don't have an overview of the object I'm dealing with. - "SQL Expression" field for metrics is extremely wonky for me. It is tiny, and when I try to resize it, all sorts of layout shifts happen. It is frustrating to work with, especially when the expression is somewhat big. Effectively, this forces me to tab to an external editor even for quick, minimal changes in such expressions. I thought it would be more convenient to reuse the two-panel layout from dashboard filter editor here. Here is how it could look: <img width="897" height="761" alt="Image" src="https://github.com/user-attachments/assets/d2177093-cdc8-4020-a7b8-9d53187440b2"; /> My example is nowhere near polished, but such layout resolves almost all my issues with the editor. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
