kgabryje opened a new pull request, #38257: URL: https://github.com/apache/superset/pull/38257
### SUMMARY When dragging columns or metrics outside of any folder in the dataset folders editor, the drop was silently rejected with no feedback. This adds a warning toast to inform users that items should be placed inside folders. The message is context-aware: - **Columns only**: "Columns should be inside folders" - **Metrics only**: "Metrics should be inside folders" - **Both**: "Columns and metrics should be inside folders" ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before**: Dropping items outside folders silently does nothing. **After**: A warning toast appears explaining that items should be inside folders. ### TESTING INSTRUCTIONS 1. Enable feature flag `DATASET_FOLDERS` 2. Open a dataset with multiple metrics and columns 3. Drag a column and drop it outside of any folder (e.g., in the empty space between folders or at root level) 4. Verify a warning toast appears: "Columns should be inside folders" 5. Repeat with a metric — toast should say "Metrics should be inside folders" 6. Select both a column and a metric, drag outside folders — toast should say "Columns and metrics should be inside folders" ### ADDITIONAL INFORMATION - [x] Has associated issue: https://app.shortcut.com/preset/story/99974 - [x] Required feature flags: `DATASET_FOLDERS` - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
