dosubot[bot] commented on issue #38315:
URL: https://github.com/apache/superset/issues/38315#issuecomment-3981362744

   <!-- Answer -->
   This is a confirmed issue with the legacy MapBox chart. These fields are 
defined in the UI but **never actually applied** during chart rendering due to 
implementation gaps:
   
   **Opacity field**: The value is passed through the component hierarchy but 
[`ScatterPlotGlowOverlay` doesn't include `globalOpacity` in its 
propTypes](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx)
 and never uses it in the rendering logic.
   
   **Viewport fields (longitude, latitude, zoom)**: These values are [never 
extracted from formData in 
transformProps](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/plugins/legacy-plugin-chart-map-box/src/transformProps.js).
 Instead, the [MapBox component calculates the initial viewport from data 
bounds](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/plugins/legacy-plugin-chart-map-box/src/MapBox.jsx)
 using `WebMercatorViewport`, completely ignoring user-configured defaults.
   
   There have been some related fixes:
   - [PR #37168](https://github.com/apache/superset/pull/37168) added 
`globalOpacity` prop support for a MapBox implementation
   - [PR #33364](https://github.com/apache/superset/pull/33364) fixed viewport 
handling for deck.gl multi-layer charts
   
   However, these may apply to different deck.gl chart variants rather than the 
`legacy-plugin-chart-map-box`. This appears to be a legitimate bug that would 
require code changes to properly wire up these controls.
   
   
   <!-- Dosu Comment Footer -->
   *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
   
   ---
   <sup>How did I do? 
[Good](https://app.dosu.dev/response-feedback/1c086858-3b55-445a-a35a-b1b3723981b5?feedback_type=great_response)
 | 
[Irrelevant](https://app.dosu.dev/response-feedback/1c086858-3b55-445a-a35a-b1b3723981b5?feedback_type=irrelevant_answer)
 | 
[Incorrect](https://app.dosu.dev/response-feedback/1c086858-3b55-445a-a35a-b1b3723981b5?feedback_type=incorrect_sources)
 | 
[Verbose](https://app.dosu.dev/response-feedback/1c086858-3b55-445a-a35a-b1b3723981b5?feedback_type=too_verbose)
 | 
[Hallucination](https://app.dosu.dev/response-feedback/1c086858-3b55-445a-a35a-b1b3723981b5?feedback_type=hallucination)
 | [Report 
🐛](https://app.dosu.dev/response-feedback/1c086858-3b55-445a-a35a-b1b3723981b5?feedback_type=bug_report)
 | 
[Other](https://app.dosu.dev/response-feedback/1c086858-3b55-445a-a35a-b1b3723981b5?feedback_type=other)</sup>
   
   [![Chat with 
Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github)&nbsp;[![Open
 in 
Cursor](https://dosu.dev/dosu-in-cursor.svg)](https://cursor.com/link/prompt?text=This%20is%20a%20confirmed%20issue%20with%20the%20legacy%20MapBox%20chart.%20These%20fields%20are%20defined%20in%20the%20UI%20but%20%2A%2Anever%20actually%20applied%2A%2A%20during%20chart%20rendering%20due%20to%20implementation%20gaps%3A%0A%0A%2A%2AOpacity%20field%2A%2A%3A%20The%20value%20is%20passed%20through%20the%20component%20hierarchy%20but%20%5B%60ScatterPlotGlowOverlay%60%20doesn%27t%20include%20%60globalOpacity%60%20in%20its%20propTypes%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx%29%20and%20never%20uses%20it%20in%20the%20rendering%20logic.%0A%0A%2A%2AViewport%20fields%20%28longitude%2C%20latitude%2C%20zoom%29%2A%2A
 
%3A%20These%20values%20are%20%5Bnever%20extracted%20from%20formData%20in%20transformProps%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/plugins/legacy-plugin-chart-map-box/src/transformProps.js%29.%20Instead%2C%20the%20%5BMapBox%20component%20calculates%20the%20initial%20viewport%20from%20data%20bounds%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/plugins/legacy-plugin-chart-map-box/src/MapBox.jsx%29%20using%20%60WebMercatorViewport%60%2C%20completely%20ignoring%20user-configured%20defaults.%0A%0AThere%20have%20been%20some%20related%20fixes%3A%0A-%20%5BPR%20%2337168%5D%28https%3A//github.com/apache/superset/pull/37168%29%20added%20%60globalOpacity%60%20prop%20support%20for%20a%20MapBox%20implementation%0A-%20%5BPR%20%2333364%5D%28https%3A//github.com/apache/superset/pull/33364%29%20fixed%20viewport%20handling%20for%20deck.gl%20multi-layer%20charts%0A%0AHowever%2C%2
 
0these%20may%20apply%20to%20different%20deck.gl%20chart%20variants%20rather%20than%20the%20%60legacy-plugin-chart-map-box%60.%20This%20appears%20to%20be%20a%20legitimate%20bug%20that%20would%20require%20code%20changes%20to%20properly%20wire%20up%20these%20controls.)&nbsp;[![Join
 
Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share
 on 
X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/38315)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to