codeant-ai-for-open-source[bot] commented on code in PR #38345:
URL: https://github.com/apache/superset/pull/38345#discussion_r2873472730
##########
superset-frontend/plugins/plugin-chart-echarts/src/Histogram/types.ts:
##########
@@ -31,6 +31,7 @@ export type HistogramFormData = QueryFormData & {
xAxisFormat: string;
xAxisTitle: string;
yAxisFormat: string;
+ yAxisLogScale: boolean;
Review Comment:
**Suggestion:** The `yAxisLogScale` property should be marked as optional
(`yAxisLogScale?: boolean`) for backward compatibility with existing saved
charts that were created before this feature was added. Otherwise, TypeScript
type checking will fail when loading old chart configurations where this field
is undefined. [type error]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ Existing histogram charts fail to load/render for users.
- ❌ Breaking change for all saved dashboards containing histograms.
- ⚠️ TypeScript compilation errors with legacy test data fixtures.
```
</details>
```suggestion
yAxisLogScale?: boolean;
```
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Open existing histogram chart saved before this PR was deployed (access
via
`/explore/?slice_id=<existing_id>` endpoint).
2. Frontend fetches chart formData from Superset backend API
(`/api/v1/chart/<id>` or
similar chart data endpoint).
3. Response JSON contains legacy chart configuration without `yAxisLogScale`
field (field
didn't exist when chart was created).
4. TypeScript type `HistogramFormData` at `types.ts:34` expects required
boolean property
`yAxisLogScale`.
5. Code accessing `formData.yAxisLogScale` receives `undefined` at runtime,
causing
potential undefined reference errors in ECharts option builders or
TypeScript strict mode
compilation failures during build process when processing legacy chart
fixtures.
```
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/src/Histogram/types.ts
**Line:** 34:34
**Comment:**
*Type Error: The `yAxisLogScale` property should be marked as optional
(`yAxisLogScale?: boolean`) for backward compatibility with existing saved
charts that were created before this feature was added. Otherwise, TypeScript
type checking will fail when loading old chart configurations where this field
is undefined.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38345&comment_hash=7269f5f90039244c322916ed81ae8bf8471324ddf8a96d5e5a4b1c08856ca870&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38345&comment_hash=7269f5f90039244c322916ed81ae8bf8471324ddf8a96d5e5a4b1c08856ca870&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
