villebro commented on code in PR #37531:
URL: https://github.com/apache/superset/pull/37531#discussion_r2873741093
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/Bar/transformProps.test.ts:
##########
@@ -63,7 +63,7 @@ describe('Bar Chart X-axis Time Formatting', () => {
});
const transformedProps = transformProps(
- chartProps as EchartsTimeseriesChartProps,
+ chartProps as unknown as EchartsTimeseriesChartProps,
Review Comment:
This looks slightly strange. I tried reverting this change and it didn't
raise a type error during build time. Did you run into issues without thus
double type cast?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]