rusackas commented on code in PR #38155:
URL: https://github.com/apache/superset/pull/38155#discussion_r2874090769
##########
.github/workflows/pre-commit.yml:
##########
@@ -61,11 +61,17 @@ jobs:
restore-keys: |
pre-commit-v2-${{ runner.os }}-py${{ matrix.python-version }}-
+ - name: Get changed files
+ id: changed_files
+ uses: ./.github/actions/file-changes-action
+ with:
+ output: ' '
+
- name: pre-commit
run: |
set +e # Don't exit immediately on failure
- export SKIP=eslint-frontend,type-checking-frontend
- pre-commit run --all-files
+ export SKIP=type-checking-frontend
Review Comment:
Can we double check that eslint doesn't still have some applicable rules
that oxlint doesn't yet cover? Last I checked we're still stuck in a bit of a
transition phase as oxlint comes to maturity on certain rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
