bito-code-review[bot] commented on code in PR #38360:
URL: https://github.com/apache/superset/pull/38360#discussion_r2879463936
##########
superset-extensions-cli/src/superset_extensions_cli/cli.py:
##########
@@ -217,17 +222,36 @@ def copy_frontend_dist(cwd: Path) -> str:
def copy_backend_files(cwd: Path) -> None:
+ """Copy backend files based on pyproject.toml build configuration
(validation already passed)."""
dist_dir = cwd / "dist"
- extension = read_json(cwd / "extension.json")
- if not extension:
- click.secho("❌ No extension.json file found.", err=True, fg="red")
- sys.exit(1)
+ backend_dir = cwd / "backend"
Review Comment:
<!-- Bito Reply -->
The suggestion replaces a bare `assert pyproject` with an explicit check
that provides a clear error message and exits gracefully if `pyproject.toml`
can't be read. This improves error handling in the `copy_backend_files`
function, preventing unhandled AssertionErrors and ensuring consistent CLI
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
