sadpandajoe opened a new pull request, #38368: URL: https://github.com/apache/superset/pull/38368
### SUMMARY Migrates DashboardList Cypress E2E tests (`dashboard_list/list.test.ts`, `dashboard_list/filter.test.ts`) to Jest + React Testing Library. This follows the same pattern established by the ChartList and DatasetList migrations. **What changed:** - Deleted 2 Cypress test files (14 tests total, 3 of which were already skipped) - Created 5 new RTL test files + 1 shared test helpers module (52 tests total) - Refactored existing `DashboardList.test.tsx` to use shared helpers and added filter encoding tests **Test file structure:** | File | Tests | Scope | |------|-------|-------| | `DashboardList.test.tsx` | 12 | Rendering, fetching, view switching, filter encoding (rison-decoded) | | `DashboardList.listview.test.tsx` | 9 | Table columns, sort, bulk select/export/delete, certified badges | | `DashboardList.cardview.test.tsx` | 9 | Card rendering, sort dropdown, bulk select/export/delete | | `DashboardList.behavior.test.tsx` | 5 | Favorite/unfavorite with star flip, delete with dialog close, edit title | | `DashboardList.permissions.test.tsx` | 16 | Permission-gated UI for admin/read-only/export-only/write-only/anonymous | | `DashboardList.testHelpers.tsx` | — | Shared mocks, render helper, API endpoints, rison query parsing | **Test quality highlights:** - Sort and filter assertions decode rison query parameters and check `order_column`/`order_direction`/`filters` values (not just call counts) - Strict fetch-mock catch-all throws on unmatched requests instead of silently returning empty data - Mutation tests verify both API calls and post-mutation UI state (star flip, dialog close, modal close) - All routes are named for reliable override via `removeRoutes` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — test-only change, no UI modifications. ### TESTING INSTRUCTIONS ```bash # Run all DashboardList tests npm run test -- --maxWorkers=2 src/pages/DashboardList/ # Expected: 5 suites, 52 tests, all passing (~70s) ``` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [x] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
