rusackas opened a new pull request, #38371: URL: https://github.com/apache/superset/pull/38371
## SUMMARY Fixes #37344 - Minor tick gridlines were overly bright and prominent in dark themes. ## BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF The issue reporter provided screenshots showing overly bright minor gridlines in dark theme: - Issue: https://github.com/apache/superset/issues/37344 ## DESCRIPTION OF CHANGE Minor tick gridlines were using ECharts default colors instead of theme-aware colors, making them overly bright and visually dominant in dark themes. This change applies the theme's `colorBorderSecondary` token to minor gridlines for both x and y axes. **Changes:** - Added `minorSplitLine` configuration to `xAxis` theme - Added `minorSplitLine` configuration to `yAxis` theme - Uses `colorBorderSecondary` token for appropriate subtlety This ensures minor gridlines maintain proper visual hierarchy (less prominent than major gridlines) while being theme-aware across both light and dark modes. ## TESTING INSTRUCTIONS 1. Enable dark theme in Superset 2. Create a chart with visible gridlines (e.g., time series, bar chart) 3. Verify minor gridlines are now subtle and appropriately colored 4. Switch to light theme and verify minor gridlines still look good ## ADDITIONAL INFORMATION - **Type**: Bug fix (cosmetic) - **Scope**: ECharts-based visualizations - **Breaking Change**: No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
