amotl commented on code in PR #38358:
URL: https://github.com/apache/superset/pull/38358#discussion_r2896274435
##########
superset/db_engine_specs/crate.py:
##########
@@ -49,7 +49,7 @@ class CrateEngineSpec(BaseEngineSpec):
"drivers": [
{
"name": "crate",
- "pypi_package": "crate[sqlalchemy]",
+ "pypi_package": "sqlalchemy-cratedb",
Review Comment:
Hi @sadpandajoe. Do you think the patch is eligible for merging now? Will
you take care about backporting it to earlier active maintenance branches of
Apache Superset, for example by using Mergify, or shall we do it manually after
this patch got merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]