codeant-ai-for-open-source[bot] commented on code in PR #38476:
URL: https://github.com/apache/superset/pull/38476#discussion_r2896989334
##########
superset/extensions/utils.py:
##########
@@ -81,7 +81,7 @@ def __init__(self, file_dict: dict[str, bytes],
source_base_path: str) -> None:
self.modules[mod_name] = (content, is_package, full_path)
# Create namespace packages for all parent modules
Review Comment:
**Suggestion:** The new namespace package creation logic may create
top-level modules that shadow existing real packages (for example if a
publisher is named like an existing package such as 'superset' or 'logging'),
causing imports for those names to resolve to empty in-memory packages instead
of the intended installed modules; you should skip creating namespace packages
for names that already exist or are importable. [logic error]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ Extensions with publisher colliding with real packages fail.
- ❌ Standard imports (e.g. logging) may resolve to empty modules.
- ⚠️ Host Superset code may crash on basic imports.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
