richardfogaca commented on code in PR #38470:
URL: https://github.com/apache/superset/pull/38470#discussion_r2897081131
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx:
##########
@@ -624,6 +627,23 @@ const FiltersConfigForm = (
forceUpdate();
};
+ const currentOperatorType: SelectFilterOperatorType =
+ formFilter?.controlValues?.operatorType ??
+ filterToEdit?.controlValues?.operatorType ??
+ SelectFilterOperatorType.Exact;
+
+ const onOperatorTypeChanged = (value: SelectFilterOperatorType) => {
Review Comment:
One edge case here: if a user already has Exact selections and then switches
to a LIKE mode, we only use the first selected value. It may be safer to
clear/reset the filter value when operatorType changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
