bito-code-review[bot] commented on PR #38443: URL: https://github.com/apache/superset/pull/38443#issuecomment-4013335951
<!-- Bito Reply --> The suggestion to wrap the SQLAlchemy connection in a context manager (or use try/finally) is valid and improves the code by preventing potential connection leaks. The validate_parameters method opens a connection that may not be closed if the method returns early due to missing parameters or during iteration, which could exhaust database handles over time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
