yousoph opened a new pull request, #38484:
URL: https://github.com/apache/superset/pull/38484
This reverts commit 77148277b96b1a3b1a60b11d364d2f92659cbd04.
There were some problems with narrow bars and labels being cut off,
reverting the fix for now and can look into a longer term improvement as a
follow up
### SUMMARY
Reverts PR #37405 which introduced issues with negative stacked bar label
positioning. It's easier to revert now and re-implement with improvements later
than to fix all the edge cases in the current implementation.
**Reverted PR**: #37405 - "feat(charts): improve negative stacked bar label
positioning and accessibility"
**Conflict Resolution**: This revert had merge conflicts with two subsequent
PRs:
- **PR #37531** (color by primary axis) - ✅ Retained the new feature
- **PR #38448** (import path refactor) - ✅ Kept the new import structure
Both features were preserved during the revert.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**After Revert** (restores pre-#37405 behavior):
- Labels for negative stacked bars positioned outside bars (original
behavior)
**Before Revert** (PR #37405 behavior):
- Labels positioned at edge inside bars with contrasting colors
- Introduced issues that need to be addressed before re-implementation
### TESTING INSTRUCTIONS
**1. Verify the revert worked (negative stacked bars):**
```sql
-- SQL Lab query for negative stacked bars
WITH chart_data AS (
SELECT * FROM (VALUES
('Bar 1', 'Segment A', -10),
('Bar 1', 'Segment B', -5),
('Bar 2', 'Segment A', -7),
('Bar 2', 'Segment B', -3)
) AS t(bar, segment, value)
)
SELECT * FROM chart_data;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
