bito-code-review[bot] commented on code in PR #38174:
URL: https://github.com/apache/superset/pull/38174#discussion_r2898607554


##########
requirements/base.in:
##########
@@ -48,3 +48,6 @@ openapi-schema-validator>=0.6.3
 # Known affected packages: Preset's 'clients' package
 # See docs/docs/contributing/pkg-resources-migration.md for details
 setuptools<81
+
+# ODPS (MaxCompute) data source support
+pyodps>=0.12.2

Review Comment:
   <!-- Bito Reply -->
   The suggestion to add an upper bound for pyodps isn't necessary, as the 
codebase already has inconsistency in dependency bounds for optional/plugin 
dependencies—some use >= only (e.g., pydruid, pyhive), others include upper 
bounds. Leaving pyodps as >= only maintains the existing pattern. Tightening 
can be addressed in a follow-up if pyodps releases a breaking change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to