bito-code-review[bot] commented on code in PR #38495:
URL: https://github.com/apache/superset/pull/38495#discussion_r2901443898
##########
superset/security/manager.py:
##########
@@ -839,9 +839,13 @@ def get_table_access_error_msg(self, tables: set["Table"])
-> str:
:returns: The error message
"""
- quoted_tables = [f"`{table}`" for table in tables]
- return f"""You need access to the following tables: {",
".join(quoted_tables)},
- `all_database_access` or `all_datasource_access` permission"""
+ quoted_tables = [f'"{table}"' for table in tables]
+ return _(
+ "You need access to the following tables: %(tables)s, "
+ "'all_database_access' or 'all_datasource_access' permission"
+ ) % {
+ "tables": ",".join(quoted_tables),
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect list formatting in error message</b></div>
<div id="fix">
The join operation uses ',' without spaces, resulting in 'table1,table2'
instead of 'table1, table2' for multiple denied tables. This affects
readability of the error message shown to users.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
"tables": ", ".join(quoted_tables),
````
</div>
</details>
</div>
<small><i>Code Review Run #0428d9</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -11363,7 +11363,7 @@ msgstr "En cours d’exécution"
#, fuzzy, python-format
msgid "Running block %(block_num)s out of %(block_count)s"
-msgstr "Exécution de l’instruction %(statement_num)s sur %(statement_count)s"
+msgstr "Exécution du bloc %(block_num)s sur %(block_count)s"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Fuzzy flag blocks translation usage</b></div>
<div id="fix">
The fuzzy flag remains on this translation entry, which means babel-compile
will skip it during .mo file generation, causing the app to display the English
msgid instead of the corrected French translation. Since the msgstr has been
updated to match the msgid placeholders, remove the fuzzy comment to enable the
translation.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
msgid "Running block %(block_num)s out of %(block_count)s"
msgstr "Exécution du bloc %(block_num)s sur %(block_count)s"
````
</div>
</details>
</div>
<small><i>Code Review Run #0428d9</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
