michael-s-molina opened a new pull request, #38518: URL: https://github.com/apache/superset/pull/38518
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY The Codecov `core-packages-ts` check was failing at 99.24% against a 100% target. This PR adds missing unit tests and `/* istanbul ignore next */` directives to untestable branches so the check passes. **Root cause:** A previous refactor (`357e35dc62`) moved `Translator.ts` and `TranslatorSingleton.ts` into `superset-core` as new files without accompanying tests, and modified theme utilities without covering the new code paths. Additionally, `getXAxis.ts` in `superset-ui-core` had two entirely untested functions. ### TESTING INSTRUCTIONS ```bash # Run superset-core tests with coverage cd superset-frontend npx jest --coverage --coverageReporters=text \ --collectCoverageFrom='packages/superset-core/src/**/*.ts' \ 'packages/superset-core' # Run superset-ui-core tests with coverage npx jest --coverage --coverageReporters=text \ --collectCoverageFrom='packages/superset-ui-core/src/**/*.ts' \ 'packages/superset-ui-core' ``` Both should report **100% statements / branches / functions / lines** for `.ts` files. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
