yousoph opened a new pull request, #38522:
URL: https://github.com/apache/superset/pull/38522
### SUMMARY
Adds comprehensive regression tests for the heatmap tooltip bug fix where
tooltips were displaying numeric indices (0, 1, 2...) instead of actual axis
values (e.g., "Monday", "Morning").
**Context:** After PR #36302 changed the heatmap data structure to use axis
indices for proper sorting, the tooltip formatter was not updated to look up
actual values from the sorted arrays. This caused tooltips to display raw
indices instead of formatted axis labels.
**What this PR does:**
- Adds 5 test cases covering different tooltip scenarios
- Ensures tooltips display actual axis values, not numeric indices
- Verifies tooltip behavior with different sort orders (alphabetical
asc/desc, value-based asc/desc)
- Tests percentage calculations use actual values when `normalizeAcross` is
enabled
- Validates tooltip handling of numeric axes
**Why these tests matter:**
These tests prevent future regressions by verifying the tooltip formatter
correctly:
1. Looks up actual x/y values from `sortedXAxisValues` and
`sortedYAxisValues` arrays
2. Uses actual values (not indices) for percentage calculations in
`totals.x[xValue]` and `totals.y[yValue]`
3. Handles different data types (strings, numbers) and sort configurations
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - Test-only changes
### TESTING INSTRUCTIONS
1. Run the heatmap tooltip tests:
```bash
cd superset-frontend
npm test -- transformProps.test.ts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
