aminghadersohi commented on PR #38525: URL: https://github.com/apache/superset/pull/38525#issuecomment-4026409211
The existing `except Exception` handler at line 125 already catches `ImportError` from this import and gracefully degrades. More importantly, Superset will still fail to start without `fastmcp` because `initialize_core_mcp_dependencies()` imports `superset.mcp_service.app` (line 267), which imports `fastmcp` at module level — and that exception is re-raised (line 273). The fix needs to be there instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
