codeant-ai-for-open-source[bot] commented on code in PR #38308:
URL: https://github.com/apache/superset/pull/38308#discussion_r2910477488
##########
superset-websocket/spec/index.test.ts:
##########
@@ -588,11 +569,11 @@ describe('server', () => {
});
test('multiple sockets', () => {
Review Comment:
**Suggestion:** The test case for multiple sockets in the `cleanChannel`
suite calls `vi.spyOn(ws2, 'readyState', 'get')` twice on the same `ws2`
instance without restoring the first spy, which will cause Vitest to throw at
runtime for attempting to spy on an already-spied property; instead, create the
spy once and change its mocked return value as needed. [logic error]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ `npm test` in superset-websocket fails in CI.
- ❌ Websocket sidecar tests cannot validate socket cleanup logic.
- ⚠️ Developers blocked from verifying websocket behavior changes.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
