aminghadersohi commented on code in PR #38531:
URL: https://github.com/apache/superset/pull/38531#discussion_r2911389518
##########
superset/mcp_service/chart/tool/get_chart_data.py:
##########
@@ -249,6 +260,8 @@ async def get_chart_data( # noqa: C901
cached_metrics = cached_form_data_dict.get("metrics", [])
cached_groupby = cached_form_data_dict.get("groupby", [])
+ _apply_extra_form_data(cached_form_data_dict,
request.extra_form_data)
Review Comment:
Fixed in commit 3ae505d — `adhoc_filters` from `form_data` are now included
in the query dicts for both the cached form_data and fallback paths, so
dashboard native filters are properly applied in all code paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
