alexandrusoare opened a new pull request, #38558: URL: https://github.com/apache/superset/pull/38558
### SUMMARY When `ALERT_REPORTS_FILTER=True` but `ALERT_REPORT_TABS=False`, native filters configured on dashboard reports were silently ignored during screenshot capture. **Root Cause**: In `get_dashboard_urls()`, native filter params were only computed inside the `ALERT_REPORT_TABS` feature flag branch, so the else branch returned URLs without filters. **Fix**: Moved the native filter computation outside the `ALERT_REPORT_TABS` conditional, gated by `ALERT_REPORTS_FILTER` instead. Now filters are applied to dashboard URLs regardless of whether the tabs feature is enabled ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
