aminghadersohi commented on code in PR #38409: URL: https://github.com/apache/superset/pull/38409#discussion_r2911817283
########## superset/mcp_service/dashboard/tool/add_chart_to_existing_dashboard.py: ########## @@ -44,6 +45,15 @@ logger = logging.getLogger(__name__) +# Compiled regex for stripping common emoji Unicode ranges from tab text. +# Not exhaustive (omits flags, skin-tone modifiers, etc.) but sufficient for +# flexible matching of dashboard tab labels. +_EMOJI_RE = re.compile( + "[\U0001f300-\U0001f9ff\U00002600-\U000027bf\U0000fe00-\U0000fe0f" Review Comment: Fixed — replaced broad Unicode ranges with specific block ranges (Misc Symbols, Emoticons, Transport, Dingbats, etc.) to avoid overlapping character ranges. ########## superset/mcp_service/dashboard/tool/add_chart_to_existing_dashboard.py: ########## @@ -44,6 +45,15 @@ logger = logging.getLogger(__name__) +# Compiled regex for stripping common emoji Unicode ranges from tab text. +# Not exhaustive (omits flags, skin-tone modifiers, etc.) but sufficient for +# flexible matching of dashboard tab labels. +_EMOJI_RE = re.compile( + "[\U0001f300-\U0001f9ff\U00002600-\U000027bf\U0000fe00-\U0000fe0f" Review Comment: Fixed — replaced broad Unicode ranges with specific block ranges (Misc Symbols, Emoticons, Transport, Dingbats, etc.) to avoid overlapping character ranges. ########## superset/mcp_service/dashboard/tool/add_chart_to_existing_dashboard.py: ########## @@ -44,6 +45,15 @@ logger = logging.getLogger(__name__) +# Compiled regex for stripping common emoji Unicode ranges from tab text. +# Not exhaustive (omits flags, skin-tone modifiers, etc.) but sufficient for +# flexible matching of dashboard tab labels. +_EMOJI_RE = re.compile( + "[\U0001f300-\U0001f9ff\U00002600-\U000027bf\U0000fe00-\U0000fe0f" Review Comment: Fixed — replaced broad Unicode ranges with specific block ranges (Misc Symbols, Emoticons, Transport, Dingbats, etc.) to avoid overlapping character ranges. ########## superset/mcp_service/dashboard/tool/add_chart_to_existing_dashboard.py: ########## @@ -44,6 +45,17 @@ logger = logging.getLogger(__name__) +# Compiled regex for stripping common emoji Unicode ranges from tab text. +# Not exhaustive (omits flags, skin-tone modifiers, etc.) but sufficient for +# flexible matching of dashboard tab labels. +_EMOJI_RE = re.compile( + "[\U0001f300-\U0001f9ff" Review Comment: Fixed — replaced broad Unicode ranges with specific block ranges (Misc Symbols, Emoticons, Transport, Dingbats, etc.) to avoid overlapping character ranges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
