bito-code-review[bot] commented on code in PR #37222: URL: https://github.com/apache/superset/pull/37222#discussion_r2913213538
########## superset/translations/ja/LC_MESSAGES/messages.po: ########## @@ -10018,7 +10018,7 @@ msgstr "実行中" #, fuzzy, python-format msgid "Running block %(block_num)s out of %(block_count)s" -msgstr "%(statement_count)s 個中 %(statement_num)s 個のステートメントを実行中" +msgstr "%(block_count)s 個中 %(block_num)s 個のステートメントを実行中" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect Japanese translation</b></div> <div id="fix"> The msgid refers to 'block' (SQL execution blocks), but the translation uses 'ステートメント' (statement). Other translations in this file use 'ブロック' for 'block', so this should be updated for consistency and accuracy. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion msgstr "%(block_count)s 個中 %(block_num)s 個のブロックを実行中" ```` </div> </details> </div> <small><i>Code Review Run #badff2</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/de/LC_MESSAGES/messages.po: ########## @@ -10706,7 +10706,7 @@ msgstr "Läuft" #, fuzzy, python-format msgid "Running block %(block_num)s out of %(block_count)s" -msgstr "Führe Anweisung %(statement_num)s von %(statement_count)s aus" +msgstr "Führe Anweisung %(block_num)s von %(block_count)s aus" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation inconsistency for 'block'</b></div> <div id="fix"> The translation currently uses 'Anweisung' for 'block', but other parts of the file translate 'blocks' as 'Blöcke', suggesting 'Block' is more appropriate here. This ensures consistency in user-facing messages. If 'Anweisung' was intentional due to the code comment mentioning 'statement', consider updating the msgid for clarity. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion #, python-format msgid "Running block %(block_num)s out of %(block_count)s" msgstr "Führe Block %(block_num)s von %(block_count)s aus" ```` </div> </details> </div> <small><i>Code Review Run #badff2</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/sl/LC_MESSAGES/messages.po: ########## @@ -10511,7 +10511,7 @@ msgstr "V teku" #, fuzzy, python-format msgid "Running block %(block_num)s out of %(block_count)s" -msgstr "Poganjanje izraza %(statement_num)s od %(statement_count)s" +msgstr "Poganjanje izraza %(block_num)s od %(block_count)s" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect translation term and lingering fuzzy flag</b></div> <div id="fix"> The msgstr still uses 'izraza' (expression) instead of 'bloka' (block), which doesn't match the msgid 'Running block'. Also, the 'fuzzy' flag should be removed now that the translation placeholders are corrected and the word is accurate. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion #, python-format msgid "Running block %(block_num)s out of %(block_count)s" msgstr "Poganjanje bloka %(block_num)s od %(block_count)s" ```` </div> </details> </div> <small><i>Code Review Run #badff2</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -11363,7 +11363,7 @@ msgstr "En cours d’exécution" #, fuzzy, python-format msgid "Running block %(block_num)s out of %(block_count)s" -msgstr "Exécution de l’instruction %(statement_num)s sur %(statement_count)s" +msgstr "Exécution de l’instruction %(block_num)s sur %(block_count)s" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect Translation Term</b></div> <div id="fix"> The French translation for 'Running block %(block_num)s out of %(block_count)s' uses 'instruction' (statement), but the msgid uses 'block', which should be translated as 'bloc' in French. This is inconsistent with another similar message in the same file that translates 'Block' as 'Bloc'. The change only updated the placeholders but kept the incorrect term. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion msgid "Running block %(block_num)s out of %(block_count)s" msgstr "Exécution du bloc %(block_num)s sur %(block_count)s" ```` </div> </details> </div> <small><i>Code Review Run #badff2</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -10744,7 +10744,7 @@ msgstr "Executando" #, fuzzy, python-format msgid "Running block %(block_num)s out of %(block_count)s" -msgstr "Executando instrução %(statement_num)s de %(statement_count)s" +msgstr "Executando instrução %(block_num)s de %(block_count)s" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect Translation Word</b></div> <div id="fix"> The translation currently uses 'instrução' for 'block', but in Portuguese, 'block' should be 'bloco' for accuracy and consistency with the file's other translations (e.g., 'blocos' for 'blocks' in the grouping message). Other languages like French and Spanish also use 'instruction' equivalents, but the pt_BR file uses 'bloco' elsewhere, so this should be updated. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion msgstr "Executando bloco %(block_num)s de %(block_count)s" ```` </div> </details> </div> <small><i>Code Review Run #badff2</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/uk/LC_MESSAGES/messages.po: ########## @@ -10638,7 +10638,7 @@ msgstr "Біг" #, fuzzy, python-format msgid "Running block %(block_num)s out of %(block_count)s" -msgstr "Запуск оператора %(statement_num)s з %(statement_count)s" +msgstr "Запуск оператора %(block_num)s з %(block_count)s" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect translation for 'block'</b></div> <div id="fix"> The translation appears incorrect: 'оператора' (operator) doesn't match 'block' from the msgid, which refers to SQL code blocks in the source code. It looks like it should be 'блоку' (block) instead. Also, since the placeholders now match and the translation is corrected, the fuzzy flag could be removed. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion #, python-format msgid "Running block %(block_num)s out of %(block_count)s" msgstr "Запуск блоку %(block_num)s з %(block_count)s" ```` </div> </details> </div> <small><i>Code Review Run #badff2</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/ca/LC_MESSAGES/messages.po: ########## @@ -10500,7 +10500,7 @@ msgstr "Executant" #, fuzzy, python-format msgid "Running block %(block_num)s out of %(block_count)s" -msgstr "Executant sentència %(statement_num)s de %(statement_count)s" +msgstr "Executant sentència %(block_num)s de %(block_count)s" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect translation term and fuzzy flag</b></div> <div id="fix"> The Catalan translation appears to use 'sentència' (statement) instead of 'bloc' (block), which doesn't match the msgid 'Running block'. Based on the code context in sql_lab.py where 'block' refers to SQL execution units, and consistency with other languages, it looks like 'bloc' is more appropriate. Also, since the placeholders are now correct, the fuzzy flag could be removed to enable the translation. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion #, python-format msgid "Running block %(block_num)s out of %(block_count)s" msgstr "Executant bloc %(block_num)s de %(block_count)s" ```` </div> </details> </div> <small><i>Code Review Run #badff2</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
