richardfogaca commented on PR #38458:
URL: https://github.com/apache/superset/pull/38458#issuecomment-4041268622
One logic gap still stands out: for aggregations that can legitimately be
negative (sum, min, max, mean), this change clamps every negative value to 0:
```
const safeMaxLabel = maxLabel > 0 ? maxLabel : 1;
const clampedLabel = Math.max(0, safeNumericLabel);
```
That avoids NaN / invisible clusters, but it also means an all-negative
dataset loses relative sizing entirely. For example, -1, -10, and -100 would
all render with the same minimum radius.
If that tradeoff is intentional, I think it should be called out explicitly
in the tests or PR description. Otherwise, I’d suggest handling negative
cluster labels in a way that still preserves ordering rather than collapsing
them all to the floor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
